fix(evaluator): add missing UriBuiltins import - #188
Merged
Conversation
main does not compile: BUILTIN_CLASSES references UriBuiltins, which lives in the impls subpackage and so needs an explicit import. open-policy-agent#156 branched before open-policy-agent#171 replaced the wildcard impls import with explicit ones, so adding UriBuiltins.class compiled on that branch. The two merged without a textual conflict, leaving the reference with no import. Signed-off-by: Sebastian Spaink <sebastianspaink@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maincurrently does not compile:BUILTIN_CLASSESreferencesUriBuiltins, which lives in theimplssubpackage and so needs an explicit import. This adds it — one line, no behaviour change.How it slipped in
Two individually green PRs that break in combination:
BuiltinRegistrystill hadimport ...ast.builtin.impls.*;, so its one-line+ UriBuiltins.class,compiled there.The merge had no textual conflict, so the reference survived without an import.
pull-request.ymlison: pull_requestonly and no workflow buildsmainon push, so nothing flagged it — it surfaces on unrelated PRs instead (e.g. #187).Worth considering separately: adding
push: branches: [main]to the build workflow so a redmainis caught directly.Testing
./gradlew buildpasses on this branch (compile, Checkstyle, PMD, all module tests). Verifiedmainat 6f5e5dc fails the same way without this change.