Skip to content

fix(evaluator): add missing UriBuiltins import - #188

Merged
sspaink merged 1 commit into
open-policy-agent:mainfrom
sspaink:fix/uri-builtins-import
Aug 7, 2026
Merged

fix(evaluator): add missing UriBuiltins import#188
sspaink merged 1 commit into
open-policy-agent:mainfrom
sspaink:fix/uri-builtins-import

Conversation

@sspaink

@sspaink sspaink commented Aug 7, 2026

Copy link
Copy Markdown
Member

main currently does not compile:

BuiltinRegistry.java:42: error: cannot find symbol
      UriBuiltins.class,
  symbol: class UriBuiltins

BUILTIN_CLASSES references UriBuiltins, which lives in the impls subpackage and so needs an explicit import. This adds it — one line, no behaviour change.

How it slipped in

Two individually green PRs that break in combination:

The merge had no textual conflict, so the reference survived without an import. pull-request.yml is on: pull_request only and no workflow builds main on push, so nothing flagged it — it surfaces on unrelated PRs instead (e.g. #187).

Worth considering separately: adding push: branches: [main] to the build workflow so a red main is caught directly.

Testing

./gradlew build passes on this branch (compile, Checkstyle, PMD, all module tests). Verified main at 6f5e5dc fails the same way without this change.

main does not compile: BUILTIN_CLASSES references UriBuiltins, which
lives in the impls subpackage and so needs an explicit import.

open-policy-agent#156 branched before open-policy-agent#171 replaced the wildcard impls import with
explicit ones, so adding UriBuiltins.class compiled on that branch.
The two merged without a textual conflict, leaving the reference with
no import.

Signed-off-by: Sebastian Spaink <sebastianspaink@gmail.com>
@sspaink
sspaink requested a review from a team as a code owner August 7, 2026 22:51
@sspaink
sspaink merged commit 7dbd95a into open-policy-agent:main Aug 7, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant